Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alignment of lemmas about monadic functions on List/Array/Vector #6883

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jan 31, 2025

This PR completes the alignment of lemmas about monadic functions on List/Array/Vector. Amongst other changes, we change the simp normal form from List.forM to ForM.forM, and correct the definition of List.flatMapM, which previously was returning results in the incorrect order. There remain many gaps in the verification lemmas for monadic functions; this PR only makes the lemmas uniform across List/Array/Vector.

@kim-em kim-em added the changelog-library Library label Jan 31, 2025
@kim-em kim-em enabled auto-merge January 31, 2025 07:08
@kim-em kim-em changed the title feat: alignment of lemmas about monadic functions on List/Array/Vector. feat: alignment of lemmas about monadic functions on List/Array/Vector Jan 31, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 31, 2025 07:20 Inactive
@kim-em kim-em added this pull request to the merge queue Jan 31, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 31, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 146f6e6b2fc7a62de17c99b1543f7e52201f2179 --onto e922edfc218090ab2e54092336c67fe3b970dfc2. (2025-01-31 07:29:22)

Merged via the queue into master with commit 6c2573f Jan 31, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants